Skip to content

chore: bump Node.js requirement to >=20#2418

Closed
Varadraj75 wants to merge 4 commits intoasyncapi:masterfrom
Varadraj75:fix/release-node20
Closed

chore: bump Node.js requirement to >=20#2418
Varadraj75 wants to merge 4 commits intoasyncapi:masterfrom
Varadraj75:fix/release-node20

Conversation

@Varadraj75
Copy link
Contributor

@Varadraj75 Varadraj75 commented Jan 20, 2026 •
edited
Loading

Description

This PR updates the Node.js version requirement to ensure compatibility with dependencies that require Node.js >= 20.

Specifically:

  • Updated .nvmrc from v18 to v20
  • Updated engines.node in package.json from >=18 to >=20

This aligns the project configuration with the minimum Node.js version required by yargs-parser and fixes the release workflow failure.

Related Issue

Fixes release workflow failure due to Node.js v18 being used in CI, which is incompatible with yargs-parser requiring Node.js >= 20.
closes #2417

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

All tests and example workflows were run locally using Node.js v20.20.0 and passed successfully.
No dependency or lockfile changes are included in this PR; only configuration files related to Node.js version were modified.

Copilot AI review requested due to automatic review settings January 20, 2026 13:01
@netlify
Copy link

netlify bot commented Jan 20, 2026 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit d33a829
🔍 Latest deploy log https://app.netlify.com/projects/modelina/deploys/698888752876af000858448e

Copilot AI reviewed Jan 20, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the minimum Node.js version requirement from 18 to 20 to align with dependency requirements (specifically yargs-parser) and fix release workflow failures.

Changes:

  • Updated .nvmrc from v18 to v20
  • Updated engines.node in package.json from >=18 to >=20

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.nvmrc Updated Node.js version specification from v18 to v20 for nvm users
package.json Updated minimum Node.js engine requirement from >=18 to >=20

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

coveralls commented Jan 20, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 21798551210

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.997%
Totals Coverage Status
Change from base Build 21798283316: 0.0%
Covered Lines: 6942
Relevant Lines: 7421
💛 - Coveralls

@giruuuuj giruuuuj mentioned this pull request Jan 20, 2026
Open
2 tasks
@Varadraj75
Copy link
Contributor Author

Varadraj75 commented Jan 29, 2026

Hi @jonaslagoni
This PR fixes the release workflow failure by aligning the Node.js version with current dependency requirements.
All CI checks are green.
Requesting your review when convenient. Thanks!

@jonaslagoni
Copy link
Member

jonaslagoni commented Jan 29, 2026

Guess this is a dependency for the CI script...

This is a breaking change for the library, have to include it in the next branch

@Varadraj75
Copy link
Contributor Author

Varadraj75 commented Jan 29, 2026

Thanks for the clarification @jonaslagoni
Understood — since bumping Node.js to >=20 is a breaking change, it shouldn’t go into master.
I’m happy to retarget this PR to the appropriate next / major release branch or open a new PR if preferred.
Please let me know how you’d like me to proceed. Thanks!

@jonaslagoni
Copy link
Member

jonaslagoni commented Feb 1, 2026

Yea feel free @Varadraj75

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jonaslagoni jonaslagoni changed the base branch from master to next February 8, 2026 14:44
@jonaslagoni jonaslagoni changed the base branch from next to master February 8, 2026 14:44
@jonaslagoni
Copy link
Member

jonaslagoni commented Feb 8, 2026

Continued in #2434

@jonaslagoni jonaslagoni closed this Feb 8, 2026
@jonaslagoni
Copy link
Member

jonaslagoni commented Feb 8, 2026

@all-contributors please add @Varadraj75 for code, infra

@allcontributors allcontributors bot mentioned this pull request Feb 8, 2026
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Feb 8, 2026

@jonaslagoni

I've put up a pull request to add @Varadraj75! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@kennethaasan kennethaasan Awaiting requested review from kennethaasan kennethaasan is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@artur-ciocanu artur-ciocanu Awaiting requested review from artur-ciocanu

@leigh-johnson leigh-johnson Awaiting requested review from leigh-johnson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Release workflow fails because Node 18 is still declared in .nvmrc and engines

3 participants

@Varadraj75 @coveralls @jonaslagoni

Comments